fix: Use timezone-aware datetime#2947
Merged
cau-git merged 2 commits intodocling-project:mainfrom Feb 13, 2026
Merged
Conversation
Updated timestamp recording to use timezone-aware datetime. Signed-off-by: Nikhil Singh <[email protected]>
Contributor
|
✅ DCO Check Passed Thanks @Ritinikhil, all your commits are properly signed off. 🎉 |
|
Related Documentation Checked 14 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the profiling utilities by replacing the deprecated datetime.utcnow() with datetime.now(timezone.utc) to comply with Python 3.12 deprecations and produce timezone-aware timestamps.
Changes:
- Updated import statement to include
timezonefrom thedatetimemodule - Replaced deprecated
datetime.utcnow()call withdatetime.now(timezone.utc)for timezone-aware timestamp generation - Minor code cleanup: removed unnecessary
.keys()call when checking dictionary membership
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dolfim-ibm
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
@Ritinikhil Looks like a valid contribution, can you please fix the formatting/linting issues? You should always rely on the |
Signed-off-by: Michele Dolfi <[email protected]>
vagenas
approved these changes
Feb 13, 2026
cau-git
approved these changes
Feb 13, 2026
cau-git
added a commit
that referenced
this pull request
Feb 17, 2026
…n models (#2999) * fix: add failed pages to DoclingDocument for page break consistency (#2939) * fix: add failed pages to DoclingDocument for page break consistency When some PDF pages fail to parse, they were not added to DoclingDocument.pages, causing page break markers to be incorrect during export. This adds failed/skipped pages with their size info (if available) to maintain correct page numbering and structure. - Add _add_failed_pages_to_document() method in StandardPdfPipeline - Add test cases for failed page handling - Add test cases for normal page handling (regression test) - Add test PDF files Signed-off-by: jhchoi1182 <[email protected]> * fix: ensure resource cleanup and simplify type hints - Wrap page_backend usage in try-finally to guarantee unload (prevents resource leaks). - Simplify redundant 'float | None | None' type hint. Signed-off-by: jhchoi1182 <[email protected]> * fix: add groundtruth for normal_4pages.pdf and exclude failing PDFs from e2e test Signed-off-by: jhchoi1182 <[email protected]> * fix: ensure correct status assertion for failed pages in tests Signed-off-by: jhchoi1182 <[email protected]> --------- Signed-off-by: jhchoi1182 <[email protected]> * fix: Use timezone-aware datetime (#2947) * Use timezone-aware datetime for profiling timestamps Updated timestamp recording to use timezone-aware datetime. Signed-off-by: Nikhil Singh <[email protected]> * run formatter Signed-off-by: Michele Dolfi <[email protected]> --------- Signed-off-by: Nikhil Singh <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> * fix(asciidoc): handle commas in image alt text (#2983) * Fix: Handle commas in AsciiDoc image alt text - Modified _parse_picture() to gracefully handle alt text containing commas - Commas in alt text are now preserved instead of causing ValueError - Added test case with realistic auto-generated alt text - split('=', 1) prevents issues when values contain '=' characters * DCO Remediation Commit for n0rdp0l <[email protected]> I, n0rdp0l <[email protected]>, hereby add my Signed-off-by to this commit: ee75249 Signed-off-by: n0rdp0l <[email protected]> * style: fix ruff formatting in test_backend_asciidoc.py Signed-off-by: n0rdp0l <[email protected]> --------- Signed-off-by: n0rdp0l <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> * chore: bump version to 2.73.1 [skip ci] * First attempt at establishing API Kserve2 facet Signed-off-by: Christoph Auer <[email protected]> * refactor: improve KServe v2 engine implementation after code review - Add comprehensive error handling to KserveV2HttpClient - Catch and wrap Timeout, ConnectionError, HTTPError with context - Validate response formats with clear error messages - Refactor URL building to eliminate duplication - Extract _build_model_url() helper method - Single source of truth for infer_url and model_metadata_url - Make URL required parameter (remove default localhost:8000) - Update ApiKserveV2*EngineOptions to require explicit URL - Add preset validation with helpful error messages - Rename constants for clarity: TRITON_* → KSERVE_V2_* - Add comment explaining KServe v2 uses Triton type system - Improve error messages with actual values - Show counts, shapes, and supported types in validation errors - Document official KServe Python SDK alternative - Note async-only requirement and alpha status - Update tests for required URL parameter Signed-off-by: Christoph Auer <[email protected]> * Cleanup in kserve http helper and options Signed-off-by: Christoph Auer <[email protected]> * Further cleanup Signed-off-by: Christoph Auer <[email protected]> * Fix for remote-services on tablemodel Signed-off-by: Christoph Auer <[email protected]> * fix: improved deserialization of engine_options (#3008) * add registry of discriminated subclasses Signed-off-by: Michele Dolfi <[email protected]> * fix detection of engine_type value Signed-off-by: Michele Dolfi <[email protected]> --------- Signed-off-by: Michele Dolfi <[email protected]> * Add options serialization improvements Signed-off-by: Christoph Auer <[email protected]> --------- Signed-off-by: jhchoi1182 <[email protected]> Signed-off-by: Nikhil Singh <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Signed-off-by: n0rdp0l <[email protected]> Signed-off-by: Christoph Auer <[email protected]> Co-authored-by: jhchoi1182 <[email protected]> Co-authored-by: Nikhil Singh <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> Co-authored-by: Felix Wente <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Michele Dolfi <[email protected]>
cau-git
added a commit
that referenced
this pull request
Feb 18, 2026
…ication) and KServe v2 API support (#2979) * feat: Inference engines abstraction for image classification model family with HF Transformers and ONNX runtime Implements runtime abstraction for image classification models with support for both ONNX Runtime and HuggingFace Transformers engines. Users can switch between engines without model retraining, similar to the object detection abstraction (#2959). Key components: - BaseImageClassificationEngine with factory pattern - OnnxRuntimeImageClassificationEngine and TransformersImageClassificationEngine implementations - Shared HfVisionModelMixin for common HF model utilities - Engine-specific configuration options - Test suite and example demonstrating runtime engine switching Signed-off-by: Christoph Auer <[email protected]> * Add missing files and re-export for backward compat Signed-off-by: Christoph Auer <[email protected]> * Don't run with OCR in the example. Signed-off-by: Christoph Auer <[email protected]> * Remove excess onnxruntime related options for inuts and outputs Signed-off-by: Christoph Auer <[email protected]> * feat: centralize torch compile defaults with DOCLING_INFERENCE_COMPILE_TORCH_MODELS Signed-off-by: Christoph Auer <[email protected]> * feat: Add Kserve2 API engine for image classifier and object detection models (#2999) * fix: add failed pages to DoclingDocument for page break consistency (#2939) * fix: add failed pages to DoclingDocument for page break consistency When some PDF pages fail to parse, they were not added to DoclingDocument.pages, causing page break markers to be incorrect during export. This adds failed/skipped pages with their size info (if available) to maintain correct page numbering and structure. - Add _add_failed_pages_to_document() method in StandardPdfPipeline - Add test cases for failed page handling - Add test cases for normal page handling (regression test) - Add test PDF files Signed-off-by: jhchoi1182 <[email protected]> * fix: ensure resource cleanup and simplify type hints - Wrap page_backend usage in try-finally to guarantee unload (prevents resource leaks). - Simplify redundant 'float | None | None' type hint. Signed-off-by: jhchoi1182 <[email protected]> * fix: add groundtruth for normal_4pages.pdf and exclude failing PDFs from e2e test Signed-off-by: jhchoi1182 <[email protected]> * fix: ensure correct status assertion for failed pages in tests Signed-off-by: jhchoi1182 <[email protected]> --------- Signed-off-by: jhchoi1182 <[email protected]> * fix: Use timezone-aware datetime (#2947) * Use timezone-aware datetime for profiling timestamps Updated timestamp recording to use timezone-aware datetime. Signed-off-by: Nikhil Singh <[email protected]> * run formatter Signed-off-by: Michele Dolfi <[email protected]> --------- Signed-off-by: Nikhil Singh <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> * fix(asciidoc): handle commas in image alt text (#2983) * Fix: Handle commas in AsciiDoc image alt text - Modified _parse_picture() to gracefully handle alt text containing commas - Commas in alt text are now preserved instead of causing ValueError - Added test case with realistic auto-generated alt text - split('=', 1) prevents issues when values contain '=' characters * DCO Remediation Commit for n0rdp0l <[email protected]> I, n0rdp0l <[email protected]>, hereby add my Signed-off-by to this commit: ee75249 Signed-off-by: n0rdp0l <[email protected]> * style: fix ruff formatting in test_backend_asciidoc.py Signed-off-by: n0rdp0l <[email protected]> --------- Signed-off-by: n0rdp0l <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> * chore: bump version to 2.73.1 [skip ci] * First attempt at establishing API Kserve2 facet Signed-off-by: Christoph Auer <[email protected]> * refactor: improve KServe v2 engine implementation after code review - Add comprehensive error handling to KserveV2HttpClient - Catch and wrap Timeout, ConnectionError, HTTPError with context - Validate response formats with clear error messages - Refactor URL building to eliminate duplication - Extract _build_model_url() helper method - Single source of truth for infer_url and model_metadata_url - Make URL required parameter (remove default localhost:8000) - Update ApiKserveV2*EngineOptions to require explicit URL - Add preset validation with helpful error messages - Rename constants for clarity: TRITON_* → KSERVE_V2_* - Add comment explaining KServe v2 uses Triton type system - Improve error messages with actual values - Show counts, shapes, and supported types in validation errors - Document official KServe Python SDK alternative - Note async-only requirement and alpha status - Update tests for required URL parameter Signed-off-by: Christoph Auer <[email protected]> * Cleanup in kserve http helper and options Signed-off-by: Christoph Auer <[email protected]> * Further cleanup Signed-off-by: Christoph Auer <[email protected]> * Fix for remote-services on tablemodel Signed-off-by: Christoph Auer <[email protected]> * fix: improved deserialization of engine_options (#3008) * add registry of discriminated subclasses Signed-off-by: Michele Dolfi <[email protected]> * fix detection of engine_type value Signed-off-by: Michele Dolfi <[email protected]> --------- Signed-off-by: Michele Dolfi <[email protected]> * Add options serialization improvements Signed-off-by: Christoph Auer <[email protected]> --------- Signed-off-by: jhchoi1182 <[email protected]> Signed-off-by: Nikhil Singh <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Signed-off-by: n0rdp0l <[email protected]> Signed-off-by: Christoph Auer <[email protected]> Co-authored-by: jhchoi1182 <[email protected]> Co-authored-by: Nikhil Singh <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> Co-authored-by: Felix Wente <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Michele Dolfi <[email protected]> * Fixes from review Signed-off-by: Christoph Auer <[email protected]> * DCO Remediation Commit for Christoph Auer <[email protected]> I, Christoph Auer <[email protected]>, hereby add my Signed-off-by to this commit: 4cdb01e Signed-off-by: Christoph Auer <[email protected]> * DCO Remediation Commit for Christoph Auer <[email protected]> I, Christoph Auer <[email protected]>, hereby add my Signed-off-by to this commit: e293ba3 Signed-off-by: Christoph Auer <[email protected]> Signed-off-by: Christoph Auer <[email protected]> * Add fallback for API variants Signed-off-by: Christoph Auer <[email protected]> * Recreate uv.lock Signed-off-by: Christoph Auer <[email protected]> --------- Signed-off-by: Christoph Auer <[email protected]> Signed-off-by: jhchoi1182 <[email protected]> Signed-off-by: Nikhil Singh <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Signed-off-by: n0rdp0l <[email protected]> Signed-off-by: Christoph Auer <[email protected]> Co-authored-by: jhchoi1182 <[email protected]> Co-authored-by: Nikhil Singh <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> Co-authored-by: Felix Wente <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Michele Dolfi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace deprecated
datetime.utcnow()withdatetime.now(timezone.utc)in profiling utilities.Motivation
datetime.utcnow()is deprecated as of Python 3.12 (see PEP 587 and Python docs).Changes
timezonefromdatetimemoduledatetime.utcnow()withdatetime.now(timezone.utc)Testing
No functional change - the returned timestamps are equivalent but now timezone-aware.